Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update strategy test document transitions with initial contract ids #1757

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Mar 8, 2024

Issue being fixed or feature implemented

Contracts registered on the first block of a strategy get a new random id, and if we want to register documents to these new contracts in the same strategy, we need to update the document transitions with the new id.

What was done?

Update the document transitions from operations with the new contract ids from contracts_with_updates. There's a corresponding PR in rs-platform-explorer. Now we can register documents to contracts that are created within the same strategy.

How Has This Been Tested?

Platform TUI strategy tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia merged commit 1e5569a into v1.0-dev Mar 10, 2024
17 checks passed
@pauldelucia pauldelucia deleted the feat/register-documents-to-supporting-contracts branch March 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants